jenkins-bot has submitted this change and it was merged.
Change subject: mediawiki.inspect#dumpTable: fix broken FF workaround
......................................................................
mediawiki.inspect#dumpTable: fix broken FF workaround
In Ib45487d10, we changed to invocation of console#table from
'console.table( data )' to 'console.table.call( console.table, data )'
to force an exception on Firefox, which doesn't define console.table
but doesn't complain if you try to invoke it. It should have been
'console.table.call( console, data )' instead.
Change-Id: Ib2252003f29586a47efb9ec534becc6396936b34
---
M resources/mediawiki/mediawiki.inspect.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mediawiki/mediawiki.inspect.js
b/resources/mediawiki/mediawiki.inspect.js
index 454d1a4..668aa2a 100644
--- a/resources/mediawiki/mediawiki.inspect.js
+++ b/resources/mediawiki/mediawiki.inspect.js
@@ -131,7 +131,7 @@
// Use Function.prototype#call to force an
exception on Firefox,
// which doesn't define console#table but
doesn't complain if you
// try to invoke it.
- console.table.call( console.table, data );
+ console.table.call( console, data );
return;
} catch (e) {}
try {
--
To view, visit https://gerrit.wikimedia.org/r/92899
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2252003f29586a47efb9ec534becc6396936b34
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
