Mdupont has uploaded a new change for review. https://gerrit.wikimedia.org/r/94469
Change subject: running pylint on the code ...................................................................... running pylint on the code Change-Id: I94f96b452d5dd5abb4b325cd3ee9396167cd1d04 Signed-off-by: James Michael DuPont <[email protected]> --- M pywikibot/bot.py M pywikibot/botirc.py M pywikibot/date.py M pywikibot/login.py M pywikibot/page.py M pywikibot/pagegenerators.py 6 files changed, 16 insertions(+), 12 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core refs/changes/69/94469/1 diff --git a/pywikibot/bot.py b/pywikibot/bot.py index ca06ce0..c6ce13a 100644 --- a/pywikibot/bot.py +++ b/pywikibot/bot.py @@ -83,7 +83,7 @@ os.rename(self.baseFilename, dfn) #print "%s -> %s" % (self.baseFilename, dfn) elif self.backupCount == -1: - if not hasattr(self, lastNo): + if not hasattr(self, 'lastNo'): self._lastNo = 1 while True: fn = "%s.%d%s" % (root, self._lastNo, ext) @@ -624,9 +624,7 @@ ver = pywikibot.__version__ # probably can be improved on # Please don't change the regular expression here unless you really # have to - some git versions (like 1.7.0.4) seem to treat lines - # containing just `$Id:` as if they were ident lines (see - # gitattributes(5)) leading to unwanted behaviour like automatic - # replacement with `$Id$` + # containing just `$Id$Id$` # or `$Id$`. m = re.search(r"\$Id" r": (\w+) \$", ver) diff --git a/pywikibot/botirc.py b/pywikibot/botirc.py index bda0284..be60f38 100644 --- a/pywikibot/botirc.py +++ b/pywikibot/botirc.py @@ -18,19 +18,22 @@ # scripts, instead of writing each one from scratch. -import logging +#import logging import logging.handlers # all output goes thru python std library "logging" module import re from ircbot import SingleServerIRCBot -from irclib import nm_to_n, nm_to_h, irc_lower, ip_numstr_to_quad +from irclib import nm_to_n, +#irc_lower +#nm_to_h +#ip_numstr_to_quad from irclib import ip_quad_to_numstr # logging levels _logger = "botirc" -from logging import DEBUG, INFO, WARNING, ERROR, CRITICAL +#from logging import DEBUG, INFO, WARNING, ERROR, CRITICAL STDOUT = 16 VERBOSE = 18 INPUT = 25 diff --git a/pywikibot/date.py b/pywikibot/date.py index 1239d48..9b27039 100644 --- a/pywikibot/date.py +++ b/pywikibot/date.py @@ -17,7 +17,7 @@ __version__ = '$Id$' # used for date recognition -import types +#import types import re # diff --git a/pywikibot/login.py b/pywikibot/login.py index 872ad68..675bf49 100644 --- a/pywikibot/login.py +++ b/pywikibot/login.py @@ -11,7 +11,7 @@ # __version__ = '$Id$' -import logging +#import logging import pywikibot from pywikibot import config, deprecate_arg from pywikibot.exceptions import NoSuchSite, NoUsername diff --git a/pywikibot/page.py b/pywikibot/page.py index ca159fd..0bbb47f 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -19,7 +19,7 @@ import htmlentitydefs import logging import re -import threading +#import threading import unicodedata import urllib import collections @@ -429,7 +429,8 @@ def previousRevision(self): """Return the revision id for the previous revision of this Page.""" - vh = self.getVersionHistory(total=2) + #vh = + self.getVersionHistory(total=2) revkey = sorted(self._revisions, reverse=True)[1] return revkey diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py index 50fd0d7..cd49d15 100644 --- a/pywikibot/pagegenerators.py +++ b/pywikibot/pagegenerators.py @@ -20,10 +20,12 @@ __version__ = '$Id$' import re -import sys +#import sys import codecs import itertools import pywikibot +import time +import date from pywikibot import config from pywikibot import deprecate_arg, i18n -- To view, visit https://gerrit.wikimedia.org/r/94469 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I94f96b452d5dd5abb4b325cd3ee9396167cd1d04 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Mdupont <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
