Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/96080


Change subject: Last modified bar tweaks
......................................................................

Last modified bar tweaks

* addressing padding
* introduce truncated-text class for ellipsis sentence truncation

Bug: 56861

Change-Id: Ibc7b37c49bb4bc393444b6130969d688710537c7
---
M includes/skins/SkinMobileBeta.php
M includes/specials/MobileSpecialPageFeed.php
M less/common/mainmenu.less
M less/common/pagelist.less
M less/common/ui.less
5 files changed, 12 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/80/96080/1

diff --git a/includes/skins/SkinMobileBeta.php 
b/includes/skins/SkinMobileBeta.php
index 0f300a2..975b1f2 100644
--- a/includes/skins/SkinMobileBeta.php
+++ b/includes/skins/SkinMobileBeta.php
@@ -34,7 +34,7 @@
        protected function getHistoryLink( Title $title ) {
                $link = parent::getHistoryLink( $title );
                if ( !$title->isMainPage() ) {
-                       $link['class'] = 'top-bar';
+                       $link['class'] = 'top-bar truncated-text';
                }
                return $link;
        }
@@ -75,7 +75,7 @@
                                        array(
                                                'text' => $name,
                                                'href' => 
SpecialPage::getTitleFor( 'UserProfile', $name )->getLocalUrl(),
-                                               'class' => 'icon-profile',
+                                               'class' => 'icon-profile 
truncated-text',
                                        ),
                                        $loginLogoutLink
                                ),
diff --git a/includes/specials/MobileSpecialPageFeed.php 
b/includes/specials/MobileSpecialPageFeed.php
index 7eb6149..e5ecdbc 100644
--- a/includes/specials/MobileSpecialPageFeed.php
+++ b/includes/specials/MobileSpecialPageFeed.php
@@ -62,7 +62,7 @@
                                Html::closeElement( 'h2' );
                }
 
-               $html .= Html::element( 'p', array( 'class' => 'mw-mf-comment' 
), $comment ) .
+               $html .= Html::element( 'p', array( 'class' => 'mw-mf-comment 
truncated-text' ), $comment ) .
                        Html::element( 'div', array( 'class' => 'info' ), 
$ts->getHumanTimestamp() );
 
                if ( $diffLink ) {
diff --git a/less/common/mainmenu.less b/less/common/mainmenu.less
index 1c66e9c..1f8ff2b 100644
--- a/less/common/mainmenu.less
+++ b/less/common/mainmenu.less
@@ -65,9 +65,6 @@
                }
 
                .icon-profile {
-                       white-space: nowrap;
-                       overflow: hidden;
-                       text-overflow: ellipsis;
                        padding-right: 40px;
                }
 
diff --git a/less/common/pagelist.less b/less/common/pagelist.less
index 1df8b50..8030e57 100644
--- a/less/common/pagelist.less
+++ b/less/common/pagelist.less
@@ -81,11 +81,8 @@
                color: #999b9e;
        }
 
+       // mw-mf-comment
        p {
-               white-space: nowrap;
-               text-overflow: ellipsis;
-               -webkit-text-overflow: ellipsis;
-               overflow: hidden;
                line-height: 1;
                margin: .25em 0 0;
        }
diff --git a/less/common/ui.less b/less/common/ui.less
index ba4aefc..d940abb 100644
--- a/less/common/ui.less
+++ b/less/common/ui.less
@@ -151,12 +151,19 @@
        }
 }
 
+.truncated-text {
+       white-space: nowrap;
+       overflow: hidden;
+       -webkit-text-overflow: ellipsis;
+       text-overflow: ellipsis;
+}
+
 // FIXME: Move to beta/alpha only place?
 .alpha,
 .beta {
        .top-bar {
                background-color: #F3F3F3;
-               padding: 8px @contentMargin;
+               padding: 5px @contentMargin;
                display: block;
                color: #666;
                a {

-- 
To view, visit https://gerrit.wikimedia.org/r/96080
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc7b37c49bb4bc393444b6130969d688710537c7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to