Cmcmahon has uploaded a new change for review. https://gerrit.wikimedia.org/r/96151
Change subject: Remove references to VE in Flow tests, not supported now ...................................................................... Remove references to VE in Flow tests, not supported now Change-Id: I2ad96d8261149bfb8bb667ae242abe8acd7cff53 --- D tests/browser/features/flow_logged_in_visualeditor.feature M tests/browser/features/step_definitions/flow_steps.rb M tests/browser/features/support/pages/flow_page.rb 3 files changed, 0 insertions(+), 29 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow refs/changes/51/96151/1 diff --git a/tests/browser/features/flow_logged_in_visualeditor.feature b/tests/browser/features/flow_logged_in_visualeditor.feature deleted file mode 100644 index 67fbe0e..0000000 --- a/tests/browser/features/flow_logged_in_visualeditor.feature +++ /dev/null @@ -1,16 +0,0 @@ [email protected] @login - -Feature: Create new topic logged in - -For now this test is assumed to run against http://en.wikipedia.beta.wmflabs.org/ only -It requires VisualEditor, the cldr extension, a "Flow QA" page, and the "Selenium user". - -Background: - Given I am logged in - - Scenario: Add new Flow topic - Given I have created a VisualEditor Flow topic - And the author link is visible - And the talk and contrib links are not visible - When I hover over the author link - Then links to talk and contrib should be visible diff --git a/tests/browser/features/step_definitions/flow_steps.rb b/tests/browser/features/step_definitions/flow_steps.rb index ff97d18..6696aad 100644 --- a/tests/browser/features/step_definitions/flow_steps.rb +++ b/tests/browser/features/step_definitions/flow_steps.rb @@ -10,10 +10,6 @@ end end -When(/^I create a (.+) into VisualEditor Flow body$/) do |flow_body| - on(FlowPage).new_topic_body_ve_element.when_present(10).send_keys(flow_body + @random_string + @automated_test_marker) -end - When(/^I create a (.+) into Flow body$/) do |flow_body| on(FlowPage).new_topic_body_element.when_present.send_keys(flow_body + @random_string + @automated_test_marker) end @@ -43,14 +39,6 @@ step 'I am on Flow page' step 'I create a Title of Flow Topic in Flow new topic' step 'I create a Body of Flow Topic into Flow body' - step 'I click New topic save' - step 'the Flow page should contain Title of Flow Topic' -end - -Given(/^I have created a VisualEditor Flow topic$/) do - step 'I am on Flow page' - step 'I create a Title of Flow Topic in Flow new topic' - step 'I create a Body of Flow Topic into VisualEditor Flow body' step 'I click New topic save' step 'the Flow page should contain Title of Flow Topic' end diff --git a/tests/browser/features/support/pages/flow_page.rb b/tests/browser/features/support/pages/flow_page.rb index 54d25f0..e0f5c2d 100644 --- a/tests/browser/features/support/pages/flow_page.rb +++ b/tests/browser/features/support/pages/flow_page.rb @@ -12,7 +12,6 @@ a(:contrib_link, text: 'contribs') text_field(:new_topic_title, name: 'topic_list[topic]') text_area(:new_topic_body, class: 'flow-newtopic-content') - div(:new_topic_body_ve, class: 've-ce-documentNode ve-ce-branchNode') button(:new_topic_save, class: 'flow-newtopic-submit') div(:flow_body, class: 'flow-container') end -- To view, visit https://gerrit.wikimedia.org/r/96151 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2ad96d8261149bfb8bb667ae242abe8acd7cff53 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: master Gerrit-Owner: Cmcmahon <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
