On Thu, Nov 15, 2018 at 9:38 AM Huji Lee <[email protected]> wrote:
>
> On Thu, Nov 15, 2018 at 11:29 AM Bryan Davis <[email protected]> wrote:
>
> > On Thu, Nov 15, 2018 at 8:32 AM Huji Lee <[email protected]> wrote:
> > >
> > > On Thu, Nov 15, 2018 at 10:30 AM Bryan Davis <[email protected]>
> > wrote:
> > >
> > > > If you are already using VirtualBox for this project, I would
> > > > personally recommend that you switch to using MediaWiki-Vagrant
> > > > (<https://www.mediawiki.org/wiki/MediaWiki-Vagrant>) to manage your VM
> > > > and use `vagrant role enable centralauth` to add CentralAuth support
> > > > to the wikifarm that mwv manages.
> > >
> > > Well the issue is I don't know how to work with Gerrit when using
> > vagrant.
> > > I want to have the ability to load a patch (with git review -d ...) and
> > to
> > > create and submit patches. To the extent that I know, vagrant does *not*
> > > integrate with my git account, right?
> >
> > MediaWiki-Vagrant manages the git clones for MediaWiki core and needed
> > extensions on the host computer (e.g. your laptop) and then shares the
> > directory that they are checked out to into the virtual machine. The
> > typical workflow for gerrit interactions then becomes using git and
> > git-review from the host computer in the correct directory.
>
> @Bryan: then I would need someone to document that workflow so I can start
> using it. It is not obvious to me how to do so based on your explanation.

The workflow is the same as documented at
<https://www.mediawiki.org/wiki/Gerrit/Tutorial> for any local use of
git + gerrit. The only special thing is which git clones you are
working from.

You will have a directory somewhere on your host computer that is a
clone of the MediaWiki-Vagrant git repository; let's call this
~/Vagrant for simplicity, but it could be anywhere. The
~/Vagrant/mediawiki directory will be created by `vagrant up` as a
clone of mediawiki/core.git. Skins will be cloned into
~/Vagrant/mediawiki/skins. Extensions will be cloned into
~/Vagrant/mediawiki/extensions.

If you wanted to test a CentralAuth patch from gerrit, you would do
these things:
* cd ~/Vagrant/mediawiki/extensions/CentralAuth
* git review -d <change number>
* Use the MediaWiki-Vagrant hosted wikifarm to test the change

To submit a patch to gerrit:
* cd ~/Vagrant/mediawiki/...
* git add ...
* git commit
* git review -R


Bryan
-- 
Bryan Davis              Wikimedia Foundation    <[email protected]>
[[m:User:BDavis_(WMF)]] Manager, Technical Engagement    Boise, ID USA
irc: bd808                                        v:415.839.6885 x6855

_______________________________________________
MediaWiki-l mailing list
To unsubscribe, go to:
https://lists.wikimedia.org/mailman/listinfo/mediawiki-l

Reply via email to