Hi Kangkai, On Sat, 2010-06-12 at 03:30 +0200, ext Yin Kangkai wrote: > On 2010-06-11, 20:58 +0800, Ameya Palande wrote: > > 1. Remove -q, QUIET, symbol and EXTRA_SYMBOL options. > > 2. Introduce --verbose and (-q) short option for --quilt. > > 3. Reformat Usage information. > > > > Signed-off-by: Ameya Palande <[email protected]> > > Thanks for the patch. > > > -options=$(getopt -o qvd:F: --long quilt,symbol:,dir:,fuzz: -- "$@") > > +options=$(getopt -o :vd:F:q --long verbose,dir:,fuzz:,quilt -- "$@") > ^ do we need the leading ':'?
With leading ':' ------------------------- am...@chotu:~/repos/kernel-source$ ./scripts/sequence-patch.sh --test Usage: sequence-patch.sh [OPTION] ------------------------- Without leading ':' we get the following getopt warning ------------------------- am...@chotu:~/repos/kernel-source$ ./scripts/sequence-patch.sh --test getopt: unrecognized option '--test' Usage: sequence-patch.sh [OPTION] ------------------------- Cheers, Ameya. _______________________________________________ MeeGo-dev mailing list [email protected] http://lists.meego.com/listinfo/meego-dev
