Heh, well the trick to use -release is nifty and I keep this in mind, and as you said the binary will always work as intended. The check for the moblin-panel module is unreliable however, for example you can always cross-compile from another environment. Having a manual check will keep this static and one would only have to see it included inside the MeeGo RPM spec file.
Thanks, I appreciate your suggestions :) Mike 2010/6/13 Aaron Bockover <[email protected]>: > Maybe more explicitly I should say - I wouldn't rely on something like > /etc/meego-release at build time, just like I wouldn't rely on > pkg-config at runtime ;-) > > --Aaron > > On Sun, Jun 13, 2010 at 5:03 PM, Aaron Bockover <[email protected]> wrote: >> Not really sure what'd be wrong with that - certainly makes your >> application more portable from a binary point of view. If you're going >> to do a configure check, I suggest instead to look for a well known >> MeeGo component via pkg-config. >> >> PKG_CHECK_MODULES(MEEGO_PANEL, moblin-panel, >> HAVE_MEEGO_PANEL=yes, HAVE_MEEGO_PANEL=no) >> >> There might be a more appropriate module to look for in your case, but >> this is guaranteed for the Netbook profile. >> >> --Aaron >> >> On Sun, Jun 13, 2010 at 2:00 PM, Mike Massonnet <[email protected]> wrote: >>> Hi Aaron, >>> >>> Thanks for your feedback! I wouldn't really be in favor of a runtime >>> check, but telling me so makes me think I can add a custom configure >>> flag --with-meego. I didn't think of this before :) >>> >>> Regards >>> Mike >>> >>> 2010/6/13 Aaron Bockover <[email protected]>: >>>> I wouldn't make your build different - you can do all of this >>>> customization at runtime. You can do something as simple (this is what >>>> I do in Banshee) as checking for /etc/meego-release to know if you >>>> need to take the MeeGo customization code path. >>>> >>>> --Aaron >>>> >>>> On Sun, Jun 13, 2010 at 11:04 AM, Mike Massonnet <[email protected]> >>>> wrote: >>>>> Is Meego providing a header file that we can use in order to make the >>>>> build different for Meego? >>>>> >>> >>> -- >>> Mike >>> >> > -- Mike _______________________________________________ MeeGo-dev mailing list [email protected] http://lists.meego.com/listinfo/meego-dev
