On 8/5/2010 9:33 PM, Masayuki Ohtak wrote:
>
> +config PCH_I2C
> + tristate "PCH I2C"
>
this is really not very descriptive. Can you make it "OKI Semi PCH I2C
controller" or something
if you has human get asked "PCH I2C"... almost nobody will know what
that means.+static irqreturn_t pch_handler_ch0(int irq, void *pData);
> +static irqreturn_t(*pch_handler_list[PCH_MAX_CHN]) (int irq, void *pData) = {
> + pch_handler_ch0,
> +};
>
hummmmmm what is this for??
> +
> +static inline void pch_setbit(void __iomem *addr, u32 offset, u32 bitmask)
> +{
> + iowrite32(((ioread32(addr + offset)) | (bitmask)), (addr + offset));
> +}
>
this might be more readble if it's made 3 lines with a local variable...
+ "Cleared the registers PCH_I2CCTL,PCH_I2CMOD,PCH_I2CBUFFOR\n,"
> + "PCH_I2CBUFSLV,PCH_I2CBUFSUB,PCH_I2CBUFMSK,\n"
>
what's that weird character ?diff --git a/drivers/i2c/i2c-dev.c
b/drivers/i2c/i2c-dev.c
+ case I2C_MODE_SEL:
> + pch_mode = arg;
> +
> + if (pch_mode <= 4) {
> + msgbuf[0] = pch_mode;
> + msg.buf = msgbuf;
> + msg.len = 1;
> + msg.flags = 0;
> + ret = i2c_transfer(client->adapter, &msg, 1);
>
in generic code??
_______________________________________________
MeeGo-dev mailing list
[email protected]
http://lists.meego.com/listinfo/meego-dev
