On Fri, Aug 20, 2010 at 09:56:13PM +0200, Carsten Munk wrote: > 2010/8/20 Foster, Dawn M <[email protected]>: > > The draft guidelines are here on this wiki page: > > http://wiki.meego.com/Contributing_code_to_MeeGo > > > My proposal: > > Have [PATCH] projectname/pac: description of patch, as standard form > of subject. > > This would allow maintainers to monitor for/flag patches for their own > project as well as potentially being useful for Metrics.
I'd have to disagree, and here is why. Imagine the following real life patch I received as part of a series produced from git-format-patch: [PATCH 05/16] Implemented dialogs for selecting Bluetooth modems Even with it's description falling within the recommended length for git commit messages, this would turn into the following for it's target project, the dialer, AKA, meego-handset-dialer: [PATCH 05/16] meego-handset-dialer/meego-handset-dialer: Implemented dialogs for selecting Bluetooth modems In this case, becuase we have these really long project/package names (artificially so I feel, but it's OT for now), the Subject: header has now left the *meaningful" information trailing beyond the typical 72 char limit of many terminal based mail programs (yes, I *am* using mutt) Even if it's not truncated for other mail readers, certainly you can see how the principle information is well outside the scope of normal visual context. Then start adding "Re: " prefixes to replies and, well, I think we get the picture. I would recommend though (and added as much to the wiki) that all patches be at least CC'ed to the project maintainer, as discoverable from the AUTHORS file and/or the "signed-off-by" in the git logs. This ensures that even if we can't/don't read meego-dev ML daily or even weekly, we, the maintainers, will have no excuse for saying we didn't see it ;) IIUC, this is how LKML does it to, CC'ing subsystem maintainer in addtion to LKML. Regards, Shane... _______________________________________________ MeeGo-dev mailing list [email protected] http://lists.meego.com/listinfo/meego-dev
