On 08/26/2010 04:01 PM, Shane Bryan wrote:
On Wed, 25 Aug 2010 14:57:11 -0700
Kevron Rees<[email protected]> wrote:
Signed-off-by: Kevron Rees<[email protected]>
---
src/dialerkeypad.cpp | 18 +++++++++---------
src/dialerkeypad.h | 4 ++--
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/dialerkeypad.cpp b/src/dialerkeypad.cpp
index 36ad42c..1e37c1c 100644
--- a/src/dialerkeypad.cpp
+++ b/src/dialerkeypad.cpp
@@ -124,7 +124,7 @@ DialerKeyPad::DialerKeyPad(DialerKeypadType
keypadType, m_optionBox(new MStylableWidget()),
m_mute(new MButton("Mute")),
m_hold(new MButton("Hold")),
- m_spkr(new MButton("Speaker")),
+ m_audiosink(new MButton("Speaker")),
Patches that are only variable name changes and not functional are not
really all that useful ;)
From a software development BKM standpoint, a variable rename that
modifies 22 lines of code is a reasonable patch; it isolates the change
into a single commit, ensuring that thereis no unintentional breakage by
making the rename.
It is better to not mix functional changes with stylistic changes
(whitespace, variable renames, code restructure, etc.)
James
_______________________________________________
MeeGo-dev mailing list
[email protected]
http://lists.meego.com/listinfo/meego-dev
