On Tue, Oct 19, 2010 at 04:00:59PM -0700, Ken Lierman wrote:
>  Add initial ak8975 eCompass driver.
> 
> We are aware of the conflicting upstream driver, and need a get well
> plan to align/merge with it, but this version is currently required.

Why is that?

Why not just use the upstream driver instead?

> Patch from: <[email protected]>

What does that mean?  Where has that phrase ever been described?

> Signed-off-by: Ken Lierman <[email protected]>

> >From 4b10b5aa9d9352c8a8d73d016435c8e58880250c Mon Sep 17 00:00:00 2001
> From: Mark Dunatov <[email protected]>

That's really a valid email address?

> Date: Tue, 7 Sep 2010 17:29:23 -0700
> Subject: [PATCH] Add driver for AK8975 eCompass
> 
> includes self test support (via self_test sysfs entry), and sens_adjust
> sysfs entry for access to Sensitivity Adjustment values.
> 
> Change-Id: I46cc020a5f77275f0c4b5f0574a777bc9ed9c907

What is this nonsense for?

Come on, if you are going to try to make a patch to replace existing
infrastructure, at least do it correctly :)

thanks,

greg k-h
_______________________________________________
Meego-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel

Reply via email to