On 10/20/2010 4:57 PM, Ken Lierman wrote:
Swhat locking is in use to ensure that nobody else talks to the hardware
during this sequence
There are no interrupts associated with this device, and the only
interface is through the virtual file read, from User Space. (The
filesystem isn't going to allow a read of this file to be preempted by
another such read.)
are you sure? which lock prevents this in the vfs level?
+
+ /* Delay a bit, then ensure the device is in Power Down mode */
+ msleep(0);
how long is this delay ??????
The duration is not critical to the HW interface... allowing a
schedule() really...
you are assuming msleep(0) is a yield() ??
> Obviously this is a static local to only this driver... so i assume
you just mean the its inconsistent to the coding standard, correct? Do
we need to get this now, or can we cycle back on this?
the acceptance criteria say that drivers need to comply with the coding
style...
_______________________________________________
Meego-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel
