On 11/9/2010 12:45 AM, Busson, SebastienX wrote:
-----Original Message-----
From: Arjan van de Ven [mailto:[email protected]]
Sent: Monday, November 08, 2010 9:34 PM
To: Busson, SebastienX
Cc: [email protected]
Subject: Re: [Meego-kernel] [PATCH 25/31] BT :
TI-ST-support-in-drivers-misc-Kconfig-and-Makefile
On 11/4/2010 3:26 PM, Busson, SebastienX wrote:
From e84374bb0f72eec7135e0d59d721cb206c663a91 Mon Sep 17 00:00:00 2001
From: Jonathan DE CESCO<[email protected]>
Date: Thu, 4 Nov 2010 19:02:21 +0100
Subject: [PATCH 3/3] TI ST support in drivers/misc Kconfig and Makefile
---
drivers/misc/Kconfig | 1 +
drivers/misc/Makefile | 2 ++
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 972f7a2..8e52c4c 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -419,5 +419,6 @@ source "drivers/misc/cmt/Kconfig"
source "drivers/misc/eeprom/Kconfig"
source "drivers/misc/cb710/Kconfig"
source "drivers/misc/iwmc3200top/Kconfig"
+source "drivers/misc/ti-st/Kconfig"
endif # MISC_DEVICES
diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
index e286cdc..cb3bacc 100644
--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -41,3 +41,5 @@ obj-y += cb710/
obj-$(CONFIG_X86_MRST) += koski_hwid.o
obj-$(CONFIG_VMWARE_BALLOON) += vmware_balloon.o
obj-$(CONFIG_CMT) += cmt/
+obj-y += ti-st/
did you try this patch in the meego kernel in its proper place?
or did you just slap it on at the end ????
I try this patch in its proper place in meego kernel.
I think perhaps it's interesting to change last line by :
+obj-$(CONFIG_TI_ST) += ti-st/
you did not try this patch in the proper place, because you have the
CONFIG_CMT line in your context, which
only gets added in the N900 section of the sequence..... which is well
after all the MRST/MFLD code, as well as being after the
place all backports go.
I really need to ask you to take more care about the patches that you
send; I'm increasingly getting the impression that you (but also some of
your
coworkers, like the IFX guys) are just throwing random things over the
wall and let me figure the mess out to see if it applies and compiles.
I'm expecting patches that get submitted to be production quality,
tested in the right place in the MeeGo kernel and generally to be something
that you feel personally proud of, rather than ashamed of. Right now,
most patches that get posted on this mailing list are a far cry away
from that.
It's by no means just you, you're just the last drop in the bucket that
triggered the overflow....
(and then the patches also must get submitted for the AC/meego-dev
kernel within a week and in linux-next in 3 months,
although for such backports the parts that are actually from upstream
have the later obviously already achieved)
_______________________________________________
MeeGo-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel
