Yo,
Just reviewed through the tree and it looks fine to me. The only thing
that caught my eye is this in memcached.c (line 2626):
+ if (handle_cas) {
+ req_cas_id = strtoull(tokens[5].value, NULL, 10);
This should be using the new safe_strtoull().
The new internal_test and the build test passes both on Mac OS X and
Ubuntu 8.04 64bit. It's really nice how we have a dedicated file for
utility functions now, things like this are always handy ;)
Cheers,
Toru
On Wed, Mar 18, 2009 at 3:46 PM, Dustin <[email protected]> wrote:
>
>
> On Mar 17, 7:05 pm, Toru Maesaka <[email protected]> wrote:
>> Heh, it's on my to-review list. Lemmie get back to you within the next 24hrs
>> ;)
>
> Great, thanks. If somebody's interested, I'll keep it open.
