Hi! Just looked through the commits. Yeah, it does make sense to add other strto* functions that we're using in the core like you did in that tree.
The test passes in my environment and the tiny issue I pointed out earlier is fixed so I have nothing to complain about :) Cheers, Toru On Thu, Mar 19, 2009 at 12:34 PM, Dustin <[email protected]> wrote: > > > > On Mar 18, 7:16 pm, Dustin <[email protected]> wrote: >> On Mar 18, 7:13 pm, Dustin <[email protected]> wrote: >> >> > How does this look? >> >> > http://github.com/dustin/memcached/commit/d0fee94ed75e304c66ba17fbd47... >> >> *doh* I looked at that several times before sending it out -- it's >> obviously wrong. How about this: >> >> http://github.com/dustin/memcached/commit/17eb0f805dfb6329735f6270179... > > OK, I took a step back and built more safe_strto* routines so I > could apply them here in the other checks this thing was doing. > > Here are the new routines and their corresponding tests: > > > http://github.com/dustin/memcached/commit/205cb1b4325b3f2c9c51007913c4aef70a25b914 > > And here is how I actually got them implemented (and tested): > > > http://github.com/dustin/memcached/commit/8ed9c02a55b7115c1ac6b16a1cf0b1e55caa6eaa >
