Hi there,

Last July I submitted a patch<https://github.com/memcached/memcached/pull/20>to 
include support for automake-1.12 in Memcached's autogen.sh.
The patch was accepted with the comment "Need a better fix for this, but 
[it will] do for now," and I was in silent agreement.
Naturally, a few weeks later, my Arch-linux system was updated with 
aclocal-1.12, and autogen.sh failed.
Instead of adding another binary check, and submitting another pull 
request, I explored what a "better fix" would be.

The better fix came from buildconf <http://buildconf.brlcad.org/>; which, 
gave an example of a clean/portable generic buildconf script.
Using said script as a guide, I was able to rewrite autogen.sh to compare 
system binaries against a minimum version, and sort-out legacy (but 
supported) binaries.

Before wasting people's time with a pull request, I'm reaching out to the 
Memcached community for review/discussion.


   1. Seems a very small set of people will use autogen. Does the Memcached 
   project really need a "better fix" for autogen.sh?
   2. Should a similar rewrite occur in "autorun.sh" script in 1.6 
   "engine-pu" branch?
   3. I'd argue support for automake family 1.7 & 1.6 should be removed, 
   yet clearly document how to define binaries for older versions.
   

Rewrite of 1.14's autogen.sh can be located @ 
https://github.com/emcconville/memcached/blob/autogen_rewrite/autogen.sh

Cheers,

Reply via email to