quark added inline comments.
INLINE COMMENTS
> revset.py:58-61
> + # TODO migrate existing functions to accept "order", and maybe wrap
> + # registered functions automatically if they do not accept "order".
> + m = methods[x[0]]
> + return m(repo, subset, *x[1:], order=order)
TODO can be removed.
> revset.py:129
> includepath=True)
> return subset & xs
>
In theory this should be:
if order == defineorder:
return xs & subset
else:
return subset & xs
But it's a bit tricky to find a counterexample. I'm still trying.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D451
To: quark, #hg-reviewers
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
