yuja added a comment.
Clever. I haven't looked this carefully, but the general direction seems fine. > @yuja Let me know if this can simplify `matchtree`, `buildtree` implementation. Actually `matchtree` can ignore extra elements in a node tuple, so the existence of `order` flag is acceptable, though this will slightly simplify the match function. > I also wonder if it makes sense to move (part of, mostly weight related) `_optimize` to runtime (`getset`), since the revset functions could have more information. For example, if `sort` gets `rev` as sort key, it could use `getset(order=any)` instead of `getset(order=define)`. Some functions like `ancestors(revs)` also do not care about the order of `revs`, and we are being conservative - using `define` for all function arguments now. That could be, perhaps. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D451 To: quark, #hg-reviewers Cc: yuja, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
