singhsrb added a comment.
Just to be clear: this change was also for readability apart from performance improvement. I personally prefer conditional code inside the loops to not keep checking if its the first or last iteration because then one can say that `the loop checks for conditions A, B and so on in each iteration` rather than `the loops checks for condition A, B and so on in each iteration but also checks for C in first iteration`. But in the end, its just a subjective personal preference more than anything else. So, I am happy to revert to the old code if you guys feel so :). REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D943 To: singhsrb, #hg-reviewers, yuja Cc: yuja, quark, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
