singhsrb added a comment.

  I just refactored the code a little more to take care of redundant loop 
execution check when `argc == 0`. I am guessing you mean you don't like the 
code in terms of readability because at runtime, this commit is strictly at 
least equal or better than the earlier code except for the case when the first 
argument is "--" (which i am guessing is not very common). Effectively, the 
extra argc check replaces the `i == 0` check in each iteration and the 
seemingly extra `i++` essentially mimics the `i++` at the end of the first 
iteration.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D943

To: singhsrb, #hg-reviewers, yuja
Cc: yuja, quark, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to