pulkit added a subscriber: quark.
pulkit added inline comments.

INLINE COMMENTS

> durin42 wrote in uncommit.py:247
> undo the _most recent_ amend? or can I run this iteratively and undo many 
> amends in sequence?

Nice catch, it should be undo the _most recent_ amend. Thanks!

> durin42 wrote in uncommit.py:265
> Should we also look for unamend_source in the extra, and potentially refuse 
> to unamend an unamend? Or not?

I don't think users will run unamend(1) and then will try to run unamend(2) 
again to unamend the first unamend. It's not intuitive in my opinion. @durham 
@quark what do you guys think here?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D821

To: pulkit, #hg-reviewers, durham
Cc: quark, durin42, ryanmce, singhsrb, durham, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to