On Mon, 12 Feb 2018 08:20:29 +0100, Denis Laxalde wrote: > > if linerange and pats: > > + # TODO: take pats as patterns with no line-range filter > > Do you mean handling "--line-range file1,from:to file2", where "file2" > would be "a pattern with no line-range filter"?
Yes. I think that is the only useful interpretation. > > @@ -3421,6 +3422,8 @@ def log(ui, repo, *pats, **opts): > > repo = scmutil.unhidehashlikerevs(repo, opts.get('rev'), 'nowarn') > > revs, differ = logcmdutil.getrevs(repo, pats, opts) > > if linerange: > > + # TODO: should follow file history from logcmdutil._initialrevs(), > > + # then filter the result by logcmdutil._makerevset() and --limit > > I remember having tried something like that earlier but it got too > complicated. Maybe your recent refactorings would make this easier now. I hope so. Currently --limit doesn't work as expected. This is totally unrelated topic, but how would we do if we want to support non-contiguous range? -L file,a:b,c:d is ambiguous because file may contain ",". _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel