yuja added inline comments. INLINE COMMENTS
> commands.py:2474 > + return util.binary(flog.read(ctx.filenode(fn))) > + except AttributeError: > + return util.binary(ctx.filectx(fn).data()) Better to test if ctx is a workingctx (i.e. `ctx.rev() is None`). Another idea is to make `wctx.filenode()` return wdirid and catch WdirUnsupported exception to fall back to the slow path. > commands.py:2475 > + except AttributeError: > + return util.binary(ctx.filectx(fn).data()) > Nit: `fctx.isbinary()` is preferred. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2938 To: sangeet259, #hg-reviewers Cc: yuja, pulkit, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
