yuja added inline comments.

INLINE COMMENTS

> yuja wrote in histedit.py:446
> Nah. It's for performance reason on ambiguous case, radix tree lookup vs 
> linear search. I've sent a patch to fix the inconsistency,
> but it was rejected because of that.
> 
> Maybe we'll need a scmutil function to document that. We shouldn't
> spill around the weird implementation detail.

BTW, it's probably wrong to rely only on _partialmatch() of unfiltered repo.
In changectx.__init__, we verify the result with `repo.changelog.rev()`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3158

To: martinvonz, durin42, #hg-reviewers, indygreg
Cc: yuja, indygreg, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to