gracinet created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers.
REVISION SUMMARY On Python3, PyInt is PyLong and it doesn't have the `value()` method. Re upcasting to PythonObj as done here works, but we might prefer taking a PythonObj from the onset (would require more testing) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6397 AFFECTED FILES rust/hg-cpython/src/dirstate.rs CHANGE DETAILS diff --git a/rust/hg-cpython/src/dirstate.rs b/rust/hg-cpython/src/dirstate.rs --- a/rust/hg-cpython/src/dirstate.rs +++ b/rust/hg-cpython/src/dirstate.rs @@ -12,7 +12,7 @@ use cpython::{ exc, PyBytes, PyDict, PyErr, PyInt, PyModule, PyObject, PyResult, - PySequence, PyTuple, Python, ToPyObject, + PySequence, PythonObject, PyTuple, Python, ToPyObject, }; use hg::{ pack_dirstate, parse_dirstate, CopyVecEntry, DirstateEntry, @@ -153,7 +153,7 @@ &dirstate_vec?, &copies?, DirstateParents { p1, p2 }, - now.value(py) as i32, + now.into_object().extract::<i32>(py)?, ) { Ok((packed, new_dirstate_vec)) => { for ( To: gracinet, #hg-reviewers Cc: durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
