yuja added a comment.

  > @@ -153,7 +153,7 @@
  > 
  >   &dirstate_vec?,
  >   &copies?,
  >   DirstateParents { p1, p2 },
  > 
  > - now.value(py) as i32, +        now.into_object().extract::<i32>(py)?,
  
  Minor thing, but I think `as_object()` is preferred since it isn't needed
  to consume the now value to extract.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6397

To: gracinet, #hg-reviewers
Cc: yuja, durin42, kevincox, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to