kevincox added inline comments.
kevincox accepted this revision.
INLINE COMMENTS
> nodemap.rs:92
> +
> + fn read(&self, nybble: u8) -> Element {
> + Element::from(RawElement::from_be(self.0[nybble as usize]))
I would call these `get` and `set`.
> nodemap.rs:111
> + }
> + write!(f, "[{}]", inner.join(", "))
> + }
You can use this helper:
https://doc.rust-lang.org/std/fmt/struct.Formatter.html#method.debug_map
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7787/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7787
To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
