gracinet added a comment.
@kevincox thanks for the review! INLINE COMMENTS > kevincox wrote in nodemap.rs:92 > I would call these `get` and `set`. Yes, I suppose `read` and `write` feel like I/O. Will do. > kevincox wrote in nodemap.rs:111 > You can use this helper: > https://doc.rust-lang.org/std/fmt/struct.Formatter.html#method.debug_map Nice, thanks for the tip REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7787/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7787 To: gracinet, #hg-reviewers, kevincox Cc: durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
