Alphare added inline comments. INLINE COMMENTS
> martinvonz wrote in matchers.rs:224 > Hmm, I don't like to replicate this into Rust. I argued for a long time with > Boris over a year ago that we should see if we can remove it from Python. He > said they (Octobus, I think) would look into that if I would just queue the > workaround for the time being. Could you see if you can simplify the Python > code first instead? > > See https://patchwork.mercurial-scm.org/patch/36755/ for discussion. I am having a little trouble reading the patchwork thread, but I gather that you want to get rid of the preventive splitting of patterns and just let the regex engine handle it on its own? Was this measure taken because of a bug in Python's `re` or because its exceptions were too coarse/unusable? I'll look into the behavior of Re2, in that case. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7922/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7922 To: Alphare, #hg-reviewers, pulkit, martinvonz Cc: martinvonz, durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
