Alphare added inline comments. INLINE COMMENTS
> Alphare wrote in matchers.rs:224 > I am having a little trouble reading the patchwork thread, but I gather that > you want to get rid of the preventive splitting of patterns and just let the > regex engine handle it on its own? Was this measure taken because of a bug in > Python's `re` or because its exceptions were too coarse/unusable? > I'll look into the behavior of Re2, in that case. I've looked into the behavior of Re2. It will return an error if the DFA runs out of memory, which seems perfectly reasonable. I will simplify the Rust code, however I feel like you're better suited than I am to fix the Python side of things, since I don't really understand the ins-and-outs of the problem. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7922/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7922 To: Alphare, #hg-reviewers, pulkit, martinvonz Cc: martinvonz, durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
