Module: Mesa
Branch: main
Commit: 16b66ab6597a756c19c842019a40cce2de443075
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=16b66ab6597a756c19c842019a40cce2de443075

Author: Kenneth Graunke <[email protected]>
Date:   Mon Jan  9 16:49:43 2023 -0800

intel/compiler: Drop dest checking in atomic code

NIR atomic operation intrinsics all have destinations.  This is just
copy and pasted from other generic intrinsic handling where that may
or may not be the case.

Reviewed-by: Lionel Landwerlin <[email protected]>
Reviewed-by: Rohan Garg <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20604>

---

 src/intel/compiler/brw_fs_nir.cpp | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/intel/compiler/brw_fs_nir.cpp 
b/src/intel/compiler/brw_fs_nir.cpp
index 53f5101b5c5..bed647ef23d 100644
--- a/src/intel/compiler/brw_fs_nir.cpp
+++ b/src/intel/compiler/brw_fs_nir.cpp
@@ -5971,9 +5971,7 @@ fs_visitor::nir_emit_surface_atomic(const fs_builder &bld,
           (nir_dest_bit_size(instr->dest) == 16 &&
            (devinfo->has_lsc || lsc_opcode_is_atomic_float(op))));
 
-   fs_reg dest;
-   if (nir_intrinsic_infos[instr->intrinsic].has_dest)
-      dest = get_nir_dest(instr->dest);
+   fs_reg dest = get_nir_dest(instr->dest);
 
    fs_reg srcs[SURFACE_LOGICAL_NUM_SRCS];
    srcs[SURFACE_LOGICAL_SRC_SURFACE] = surface;
@@ -6042,9 +6040,7 @@ fs_visitor::nir_emit_global_atomic(const fs_builder &bld,
 {
    int op = lsc_aop_for_nir_intrinsic(instr);
 
-   fs_reg dest;
-   if (nir_intrinsic_infos[instr->intrinsic].has_dest)
-      dest = get_nir_dest(instr->dest);
+   fs_reg dest = get_nir_dest(instr->dest);
 
    fs_reg addr = get_nir_src(instr->src[0]);
 

Reply via email to