Module: Mesa
Branch: main
Commit: cfd525d09730b82e635608955477a66dc56844c1
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=cfd525d09730b82e635608955477a66dc56844c1

Author: Karmjit Mahil <[email protected]>
Date:   Tue Feb 14 13:04:39 2023 +0000

pvr: Add PVR_DW_TO_BYTES()

We use dwords (32 bit) quite a bit around the code base. Previously
we used '* 4', '<< 2', or '* sizeof(uint32_t)' to go from dwords to
bytes. The conversion isn't always clear when other operations
happen in the same line, which can leave one wondering where the
multiplication came from.
PVR_DW_TO_BYTES() should make the code more obvious as well as
making the conversion more consistent.

Signed-off-by: Karmjit Mahil <[email protected]>
Reviewed-by: Frank Binns <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22658>

---

 src/imagination/include/pvr_types.h              |  13 +++
 src/imagination/vulkan/pds/pvr_pipeline_pds.c    |   3 +-
 src/imagination/vulkan/pvr_blit.c                |   4 +-
 src/imagination/vulkan/pvr_clear.c               |  17 ++--
 src/imagination/vulkan/pvr_cmd_buffer.c          | 103 ++++++++++++-----------
 src/imagination/vulkan/pvr_common.h              |   2 +-
 src/imagination/vulkan/pvr_csb.c                 |   3 +-
 src/imagination/vulkan/pvr_csb.h                 |  55 ++++++------
 src/imagination/vulkan/pvr_descriptor_set.c      |  14 +--
 src/imagination/vulkan/pvr_device.c              |  14 ++-
 src/imagination/vulkan/pvr_job_compute.c         |   4 +-
 src/imagination/vulkan/pvr_job_context.c         |  15 ++--
 src/imagination/vulkan/pvr_job_transfer.c        |  56 ++++++------
 src/imagination/vulkan/pvr_pass.c                |   3 +-
 src/imagination/vulkan/pvr_pipeline.c            |  16 ++--
 src/imagination/vulkan/pvr_query_compute.c       |   7 +-
 src/imagination/vulkan/pvr_spm.c                 |  29 ++++---
 src/imagination/vulkan/pvr_transfer_frag_store.c |  14 +--
 18 files changed, 198 insertions(+), 174 deletions(-)

Diff:   
http://cgit.freedesktop.org/mesa/mesa/diff/?id=cfd525d09730b82e635608955477a66dc56844c1

Reply via email to