Module: Mesa Branch: main Commit: 5cc7f54f15c1691719f95408e46912140473c502 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5cc7f54f15c1691719f95408e46912140473c502
Author: Tatsuyuki Ishi <ishitatsuy...@gmail.com> Date: Fri Nov 3 20:32:36 2023 +0900 radv: Remove last VS prolog reuse logic. This was broken as the field was never assigned to. This will also be dropped from the upcoming prolog/epilog lookup rework, as it adds to code complexity while the benefit of saving one hash table memory access seems questionable. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26023> --- src/amd/vulkan/radv_cmd_buffer.c | 4 ---- src/amd/vulkan/radv_private.h | 2 -- 2 files changed, 6 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 2deaa34eeb4..0155bc2e2a2 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -3871,10 +3871,6 @@ lookup_vs_prolog(struct radv_cmd_buffer *cmd_buffer, const struct radv_shader *v uint32_t hash = radv_hash_vs_prolog(key_words); - if (cmd_buffer->state.emitted_vs_prolog && cmd_buffer->state.emitted_vs_prolog_key_hash == hash && - radv_cmp_vs_prolog(key_words, cmd_buffer->state.emitted_vs_prolog_key)) - return cmd_buffer->state.emitted_vs_prolog; - u_rwlock_rdlock(&device->vs_prologs_lock); struct hash_entry *prolog_entry = _mesa_hash_table_search_pre_hashed(device->vs_prologs, hash, key_words); u_rwlock_rdunlock(&device->vs_prologs_lock); diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h index 8f69f5e282c..dc6832ce595 100644 --- a/src/amd/vulkan/radv_private.h +++ b/src/amd/vulkan/radv_private.h @@ -1737,8 +1737,6 @@ struct radv_cmd_state { uint32_t rt_stack_size; struct radv_shader_part *emitted_vs_prolog; - uint32_t *emitted_vs_prolog_key; - uint32_t emitted_vs_prolog_key_hash; uint32_t vbo_misaligned_mask; uint32_t vbo_misaligned_mask_invalid; uint32_t vbo_bound_mask;
