On Mon, Jan 11, 2016 at 11:09 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > I'm not strictly opposed to passing this in, but... why not just fix > it by removing that imho weird macro and instead use ULL suffix on > literals? Well, I thought about it, but because I didn't add that macro to the code, I wanted a solution that makes that commit work, instead of changing that commit.
Does that make sense ? Oded > > On Mon, Jan 11, 2016 at 4:07 PM, Oded Gabbay <oded.gab...@gmail.com> wrote: >> The ISO C99 standard (7.18.4) specifies that C++ >> implementations should define UINT64_C only when >> __STDC_CONSTANT_MACROS is defined. >> >> ecause we now use UINT64_C in our cpp files (since commit >> 208bfc493debe0344d0b9cb93975981f14412628), we need to add this define. >> >> This also solves compilation errors with GCC 4.8.x on ppc64le machines. >> >> Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> >> --- >> configure.ac | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/configure.ac b/configure.ac >> index 9c3d1a3..8d19dab 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -245,7 +245,7 @@ _SAVE_LDFLAGS="$LDFLAGS" >> _SAVE_CPPFLAGS="$CPPFLAGS" >> >> dnl Compiler macros >> -DEFINES="-D__STDC_LIMIT_MACROS" >> +DEFINES="-D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS" >> AC_SUBST([DEFINES]) >> case "$host_os" in >> linux*|*-gnu*|gnu*) >> -- >> 2.5.0 >> >> _______________________________________________ >> mesa-dev mailing list >> mesa-dev@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
