On 11/01/16 21:07, Oded Gabbay wrote:
The ISO C99 standard (7.18.4) specifies that C++
implementations should define UINT64_C only when
__STDC_CONSTANT_MACROS is defined.

ecause we now use UINT64_C in our cpp files (since commit
208bfc493debe0344d0b9cb93975981f14412628), we need to add this define.

This also solves compilation errors with GCC 4.8.x on ppc64le machines.

Signed-off-by: Oded Gabbay <oded.gab...@gmail.com>
---
  configure.ac | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 9c3d1a3..8d19dab 100644
--- a/configure.ac
+++ b/configure.ac
@@ -245,7 +245,7 @@ _SAVE_LDFLAGS="$LDFLAGS"
  _SAVE_CPPFLAGS="$CPPFLAGS"

  dnl Compiler macros
-DEFINES="-D__STDC_LIMIT_MACROS"
+DEFINES="-D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS"
  AC_SUBST([DEFINES])
  case "$host_os" in
  linux*|*-gnu*|gnu*)


Looks good.  Thanks.

You could also update SCons while you're at it:

diff --git a/scons/gallium.py b/scons/gallium.py
index 46dbf0e..6dcd952 100755
--- a/scons/gallium.py
+++ b/scons/gallium.py
@@ -300,7 +300,7 @@ def generate(env):

     # C preprocessor options
     cppdefines = []
-    cppdefines += ['__STDC_LIMIT_MACROS']
+    cppdefines += ['__STDC_LIMIT_MACROS', '__STDC_CONSTANT_MACROS']
     if env['build'] in ('debug', 'checked'):
         cppdefines += ['DEBUG']
     else:



Either way,

Reviewed-by: Jose Fonseca <jfons...@vmware.com>

Jose
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to