On Thursday, January 14, 2016 10:26:37 AM PST Matt Turner wrote:
> On Wed, Jan 13, 2016 at 8:33 PM, Kenneth Graunke <[email protected]> 
wrote:
> > This is no longer necessary...and it doesn't make much sense to
> > have inputs as destinations.
> > 
> > Signed-off-by: Kenneth Graunke <[email protected]>
> > ---
> 
> I don't think I realized they were ever destinations. I'm confused about how
> the
> 
>    switch (inst->dst.file) {
>    [...]
>    case ATTR:
> 
> was marked as unreachable() in dump_instructions(). Was that just broken?
> 
> Reviewed-by: Matt Turner <[email protected]>

Yes, there was a surprising amount of code that never handled this,
including dump_instructions().  It was just broken.  I had thought
this patch would delete more code.

--Ken

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to