On Sat, Apr 16, 2016 at 5:04 PM, Marek Olšák <[email protected]> wrote: > On Sat, Apr 16, 2016 at 9:40 PM, Rob Clark <[email protected]> wrote: >> On Sat, Apr 16, 2016 at 8:50 AM, Marek Olšák <[email protected]> wrote: >>> From: Marek Olšák <[email protected]> >>> >>> and remove number assignments which are consecutive >>> --- >>> src/gallium/include/pipe/p_defines.h | 378 >>> +++++++++++++++++++---------------- >>> 1 file changed, 205 insertions(+), 173 deletions(-) >>> >>> diff --git a/src/gallium/include/pipe/p_defines.h >>> b/src/gallium/include/pipe/p_defines.h >>> index 1aef21d..6bb180d 100644 >>> --- a/src/gallium/include/pipe/p_defines.h >>> +++ b/src/gallium/include/pipe/p_defines.h >>> @@ -51,49 +51,56 @@ enum pipe_error >>> /* TODO */ >>> }; >>> >>> +enum { >> >> so, I would kinda like to use named enums, and then update the state >> structs to use 'em (since it would make gcc and gdb grok them >> better).. ofc it is a big change and doesn't have to be done in all >> one go, but why not give the enum's names in this first step? > > Enum type names can't be used everywhere. A lot of states are packed > (unsigned x:n). Not sure how enums work with that. In any case, let's > add the names later if needed.
I *believe* 'enum foo name : n' works.. it has been used in other places, but I didn't verify that the structure layout was the same (and I'm not 100% sure about msvc, etc).. BR, -R > > Marek _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
