On Wed, May 25, 2016 at 4:15 PM, Kenneth Graunke <kenn...@whitecape.org> wrote: > On Friday, May 20, 2016 11:57:32 PM PDT Ilia Mirkin wrote: >> Is the else correct? What if you have, e.g., a cube view of a 2d array, >> starting at later 2? Don't you want to add the min layer in no matter what? > > I believe you're right. TextureView does set up a MinLayer for cube > views, and both BLORP and st/mesa use (Face + MinLayer). > > The dEQP tests seem to pass either way. I'll make this change.
FTR, there are no dEQP tests for texture views. (There's an OES_texture_view, which seems like it should be pretty trivial to expose, but I haven't done it since I don't want to write my own tests, and there are no dEQP ones. It's not part of GL ES 3.2 or AEP.) _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev