On 10/27/2016 09:16 PM, Marek Olšák wrote:
On Fri, Oct 21, 2016 at 5:29 PM, Tapani Pälli <tapani.pa...@intel.com> wrote:
On 10/21/2016 04:57 PM, Eero Tamminen wrote:
Hi,

On 21.10.2016 14:07, Tapani Pälli wrote:
I did run some valgrind comparisons with gfxbench4, your branch against
Mesa master. I did not spot anything obvious related to ralloc.

On i965 there's a huge load of invalid writes's and read's in general
but this happens on master as well so maybe these are not 'valid hits'.

I don't see those with master from 3 weeks ago.  Did you remember to
compile libdrm with Valgrind headers present, so that buffer allocs are
annotated for Valgrind?

Yeah, I will need to double-check that. I'll try again on Monday and we can
investigate the results together, I believe some were for Mesa core as well
related to compressed texture handling.
I guess the Sunday party was so huge that nobody was productive on Monday? :)

Seriously, it's Thursday, and there is no known issue with my latest
branch which contains all fixes from you guys. So there is no reason
to wait anymore.

Sorry, I haven't had time to sit down with Eero with this ... but I did some runs again and the errors I saw are in Mesa master on HSW and SKL when running gfxbench4 'car chase' (which also has render artifacts, bug 96743). JP has seen some of the same and I believe valgrind traces in another bug 98455 look very similar to what I saw so it's now about these changes but something we have going on anyway.

For what comes to this series, I do hope someone else on i965 also tests things, I just happened to have special interest as it can help on making optimization passes which is very much appreciated!

Thanks;

// Tapani

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to