Yes! Simplifies current situation quite a bit and makes Vulkan Android build possible, I'll submit that if/when this one lands.

There's one thing that caused problems with Android, I've marked it below .. with that removed;

Acked-by: Tapani Pälli <tapani.pa...@intel.com>


On 01/13/2017 06:51 PM, Emil Velikov wrote:
From: Emil Velikov <emil.veli...@collabora.com>


8<

+
+__BEGIN_DECLS
+void SHA1Init(SHA1_CTX *);
+void SHA1Pad(SHA1_CTX *);
+void SHA1Transform(uint32_t [5], const uint8_t [SHA1_BLOCK_LENGTH]);
+void SHA1Update(SHA1_CTX *, const uint8_t *, size_t);
+void SHA1Final(uint8_t [SHA1_DIGEST_LENGTH], SHA1_CTX *);
+__END_DECLS

__BEGIN_DECLS and __END_DECLS should be either removed or ifdeffed for Android, it does not exist. It's not used previously in Mesa so I would vote for removal.

Thanks;

// Tapani
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to