On 04/21/2017 09:48 AM, Tomasz Figa wrote:
On Fri, Apr 21, 2017 at 3:32 PM, Tapani Pälli <tapani.pa...@intel.com> wrote:
On 04/21/2017 09:24 AM, Mauro Rossi wrote:
On 04/19/2017 10:00 AM, Tomasz Figa wrote:
This series aims to improve standard conformance and application
compatibility of Mesa EGL Android code, by changing the window
surface
code to properly handle cases when the buffer queue backing the
native
window is abandoned, which is relied on camera and video
frameworks.
Changes from previous RFC patch:
- split trivial code moving into a separate patch (Emil),
- fix previous rebase error,
- use cancelBuffer when destroying the surface to not confuse
the
consumer (video framework relies on this behavior).
Tomasz Figa (3):
egl/android: Move droid_{alloc,free}_local_buffers up the file
egl/android; Use ANativeWindow::cancelBuffer in destroySurface
egl/android: Dequeue buffers inside EGL calls (v2)
src/egl/drivers/dri2/egl_dri2.h | 1 +
src/egl/drivers/dri2/platform_android.c | 182
+++++++++++++++++---------------
2 files changed, 97 insertions(+), 86 deletions(-)
2017-04-20 12:22 GMT+02:00 Tapani Pälli <tapani.pa...@intel.com
<mailto:tapani.pa...@intel.com>>:
Went through these changes and everything looks good to me, only one
typo (that causes compilation to fail) spotted on the 3rd patch.
With these changes default wallpaper works properly \o/
For the series:
Reviewed-by: Tapani Pälli <tapani.pa...@intel.com
<mailto:tapani.pa...@intel.com>>
Hi Tapani,
could you send me the diff to correct the typo please?
https://lists.freedesktop.org/archives/mesa-dev/2017-April/152492.html
I'm really sorry for these typos, I had to cherry pick this back and
forth (and fixup differences manually) between master and ChromeOS
branch, because master doesn't build at all with ChromeOS due to some
missing dependencies (zlib and too old libdrm)...
Is it confirmed that commit 4d45584 "android: fix segfault within
swap_buffers"
will be reverted after applying this series?
I haven't explicitly checked for that, we have reverted that commit in
Android-IA tree though and in place we have v1 of that patch which looks
like this:
https://lists.freedesktop.org/archives/mesa-dev/2017-March/146776.html
Yes, we should revert it, actually even before my patch is applied,
because the current version is completely wrong and breaks more than
fixes. Then I can rebase my patch on top of the revert.
Sure, I'll push such revert.
// Tapani
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
