On Tue, May 02, 2017 at 04:25:42PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery <nanleych...@gmail.com> > wrote: > > > Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> > > --- > > src/intel/vulkan/genX_cmd_buffer.c | 18 +++++++++++++++--- > > 1 file changed, 15 insertions(+), 3 deletions(-) > > > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > > b/src/intel/vulkan/genX_cmd_buffer.c > > index 0ea378fde2..a981b00f67 100644 > > --- a/src/intel/vulkan/genX_cmd_buffer.c > > +++ b/src/intel/vulkan/genX_cmd_buffer.c > > @@ -216,7 +216,7 @@ color_is_zero_one(VkClearColorValue value, enum > > isl_format format) > > } > > > > static void > > -color_attachment_compute_aux_usage(struct anv_device *device, > > +color_attachment_compute_aux_usage(struct anv_cmd_buffer * const > > cmd_buffer, > > > > I t may be better to just pass in the framebuffer and attachment index > rather than the whole command buffer. Slso, I think you're getting a bit > over-excited with the constness. :-) > >
The command buffer is used to look up the render pass in the next patch. If you'd like me to pass in the render pass and framebuffer I could do that alternatively. At one point I considered creating a keyboard shortcut to make typing 'const' easier :). I'm open to hearing your thoughts about our use of it though. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
