> -----Original Message----- > From: Palli, Tapani > Sent: Thursday, May 18, 2017 11:51 AM > To: Chih-Wei Huang <cwhu...@android-x86.org>; Xu, Randy > <randy...@intel.com> > Cc: ML mesa-dev <mesa-dev@lists.freedesktop.org>; Emil Velikov > <emil.l.veli...@gmail.com> > Subject: Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL > configure and reorder the list > > On 05/18/2017 06:41 AM, Chih-Wei Huang wrote: > > 2017-05-18 11:26 GMT+08:00 Xu, Randy <randy...@intel.com>: > >>> -----Original Message----- > >>> From: Chih-Wei Huang [mailto:cwhu...@android-x86.org] > >>> Sent: Thursday, May 18, 2017 11:04 AM > >>> To: Xu, Randy <randy...@intel.com> > >>> Cc: Emil Velikov <emil.l.veli...@gmail.com>; ML mesa-dev <mesa- > >>> d...@lists.freedesktop.org> > >>> Subject: Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to > >>> EGL configure and reorder the list > >>> > >>> 2017-05-12 12:04 GMT+08:00 Xu, Randy <randy...@intel.com>: > >>>> Thanks, Emil > >>>> > >>>> dEQP has patch to exclude 565 blend cases (commit named "Exclude > >>> RGB565 blending cases from the must-pass"), so we don’t need any > >>> patches now. > >>> > >>> Hi Randy, Tapani, > >>> I think we still need a patch. Right? > >>> I see the similar patch is still applied to Android-IA codebase. > >> Which patch do you means? As Google has excluded the RGB565 for > >> blending test, we don’t need patch Mesa > > This one: > > https://github.com/android-ia/external- > mesa/commit/72d5e389c6adfbca8ec > > 18885c93191dc62c78c82 > > > > It's just applied. Isn't it? > > Yesterday without this patch > > the color format is mismatch apparently. > > > Yeah we do need this. TBH I don't quite understand why but will try to figure > it out. I remember we used to have a patch in Surfaceflinger at one point > because visual was hardcoded there and this might be related. > > // Tapani
Sorry, that's for different issue, I mix it with RGB565 blending one. This patch is required because some Android GLES test apps, like gl2_basic, need to create RGBA8888 surface. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev