2017-05-22 19:51 GMT+02:00 Lucas Stach <[email protected]>: > Am Dienstag, den 16.05.2017, 21:31 +0200 schrieb Christian Gmeiner: >> Hi Wladimir. >> >> I started working on this topic last week and thought some time on how >> to add those ext texture formats in a clean and nice way. I come up >> with this patches: >> >> https://github.com/austriancoder/mesa/commit/1fac9dd179976dce3d991bb0715707021c093f1a.patch >> https://github.com/austriancoder/mesa/commit/f408fc40a028fa00e87900e6fd4cce65ee6640c2.patch >> >> IMO it is a simpler implementation as I do not need two variants of >> macros (base and extended) and there is no need for >> translate_texture_format_ext(..). >> What is your opinion about it? > > This looks much cleaner. I like it! > > Just a heads up if you haven't noticed: the first patch is broken, as > sv->base isn't initialized yet at the point where the format is > converted. I had to apply the following diff to make it work: > > ------------------------------------>8------------------------------------ > - const uint32_t format = translate_texture_format(sv->base.format); > + const uint32_t format = translate_texture_format(so->format); > ------------------------------------8<------------------------------------ >
Thx - will send out updated patches the next days. I quite busy with lot of stuff atm but a long weekend is coming :) greets -- Christian Gmeiner, MSc https://www.youtube.com/user/AloryOFFICIAL https://soundcloud.com/christian-gmeiner _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
