On Wednesday, 2017-07-19 09:57:34 +0100, Daniel Stone wrote: > Adding linux-dmabuf Wayland protocol files as generated did the right > thing, by prepending $(MKDIR_GEN) so autotools didn't try to write into > a build directory which didn't yet exist. > > Unfortunately MKDIR_GEN needs to be defined in every Makefile it's used > in, and src/egl/ didn't actually have it. As unset variables expand to > NULL, it was silently being skipped.
"expand to nothing" is clearer IMO, but I'm really nit-picking here (: Reviewed-by: Eric Engestrom <[email protected]> > > Copy & paste the defintion to make sure drivers/dri2/ exists before we > try to generate files into it. > > Signed-off-by: Daniel Stone <[email protected]> > Reported-by: Nick Sarnie <[email protected]> > Reported-by: Mike Lothian <[email protected]> > Fixes: 02cc35937277 ("egl/wayland: Use linux-dmabuf interface for buffers") > --- > src/egl/Makefile.am | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/egl/Makefile.am b/src/egl/Makefile.am > index 19295de3ed..52ded15145 100644 > --- a/src/egl/Makefile.am > +++ b/src/egl/Makefile.am > @@ -21,6 +21,8 @@ > > include Makefile.sources > > +MKDIR_GEN = $(AM_V_at)$(MKDIR_P) $(@D) > + > BUILT_SOURCES = > > AM_CFLAGS = \ > -- > 2.13.2 > _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
