On 19 July 2017 at 09:57, Daniel Stone <[email protected]> wrote: > Adding linux-dmabuf Wayland protocol files as generated did the right > thing, by prepending $(MKDIR_GEN) so autotools didn't try to write into > a build directory which didn't yet exist. > > Unfortunately MKDIR_GEN needs to be defined in every Makefile it's used > in, and src/egl/ didn't actually have it. This is way off. One can AC_SUBST() it in configure.ac - simply nobody bothered. Can you please reword or drop this hunk?
> As unset variables expand to > NULL, it was silently being skipped. > > Copy & paste the defintion to make sure drivers/dri2/ exists before we > try to generate files into it. > > Signed-off-by: Daniel Stone <[email protected]> > Reported-by: Nick Sarnie <[email protected]> > Reported-by: Mike Lothian <[email protected]> > Fixes: 02cc35937277 ("egl/wayland: Use linux-dmabuf interface for buffers") Regardless of the above nitpick Reviewed-by: Emil Velikov <[email protected]> Thanks Emil _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
