On Wed, Nov 22, 2017 at 10:53 PM, Ian Romanick <i...@freedesktop.org> wrote:
> On 11/21/2017 10:01 AM, Marek Olšák wrote:
>> From: Marek Olšák <marek.ol...@amd.com>
>>
>> vbo_context: 21520 -> 20344 bytes
>> ---
>> src/mesa/main/mtypes.h | 8 ++++----
>> src/mesa/vbo/vbo_context.h | 4 ++--
>> src/mesa/vbo/vbo_exec_draw.c | 2 +-
>> src/mesa/vbo/vbo_save_draw.c | 2 +-
>> 4 files changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
>> index 67711d8..660b1a5 100644
>> --- a/src/mesa/main/mtypes.h
>> +++ b/src/mesa/main/mtypes.h
>> @@ -1452,31 +1452,31 @@ struct gl_pixelstore_attrib
>> };
>>
>>
>> /**
>> * Vertex array information which is derived from gl_array_attributes
>> * and gl_vertex_buffer_binding information. Used by the VBO module and
>> * device drivers.
>> */
>> struct gl_vertex_array
>> {
>> - GLint Size; /**< components per element (1,2,3,4) */
>> GLenum16 Type; /**< datatype: GL_FLOAT, GL_INT, etc */
>> GLenum16 Format; /**< default: GL_RGBA, but may be GL_BGRA */
>> - GLsizei StrideB; /**< actual stride in bytes */
>> - GLuint _ElementSize; /**< size of each element in bytes */
>> - const GLubyte *Ptr; /**< Points to array data */
>> + GLshort StrideB; /**< actual stride in bytes */
>
> It looks like the largest value anyone currently advertises for
> MaxVertexAttribStride is 2048. We should probably have a check
> somewhere that someone doesn't try to use 65537.
I'm not sure where the check should be.
Marek
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
