Your attached patch looks good to me. You can add my r-b to it.
Quoting Jon Turney (2018-01-15 11:50:04)
> On 12/01/2018 17:33, Dylan Baker wrote:
> > Maybe this is correct, but it makes me nervous treating with_gallium as
> > equivalent to with_dri, since gallium drivers can be built dri-less
> > (gallium-xlib, and some other configurations on windows). I think something
> > like:
> >
> > with_glx = get_option('glx')
> > if with_glx == 'auto'
> > if with_dri
> > with_glx = 'dri'
> > elif with_gallium
> > # Even when building just gallium drivers the user probably wants dri
> > with_glx = 'dri'
> > with_dri = true
> > elif with_platform_x11 and with_any_opengl and not with_any_vk
> > # The automatic behavior should not be to turn on xlib based glx when
> > # building only vulkan drivers
> > with_glx = 'xlib'
> > else
> > with_glx = 'disabled'
> > endif
> > + elif with_glx == 'dri'
> > + if with_gallium
> > + with_dri = true
> > + endif
> > endif
> >
> >
> > Would achieve the correct result, be simpler, and avoid accidentally adding
> > dri
> > sources when we shouldn't.
>
> Ah, yes. I'd completely failed to spot that in the 'auto' case above.
>
> How about the attached?
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
