On 02/01/2018 12:32 AM, mathias.froehl...@gmx.net wrote:
From: Mathias Fröhlich <mathias.froehl...@gmx.net>Hi, Thanks for the review! This is the starting point to a patch series that I intent to feed. The aim is to get rid of some VERT_ATTRIB_MAX long loops that currently happen at about any draw call. The series tries to separate out one of the depencies of the attribute aliasing code as a preparation of the above. It uses static const tables for the aliasing mapping. Also there is some cleanup to make use of these tables. v2: Use GLubyte instead of unsigned char Remove _ from enum *_MAX values. Change comment style. Add Comments. Put 2 empty lines between functions. Change log message. This series was now rebased to v1 several times during the past weeks. Nevertheless the original v1 series past the rebases did not regress piglit quick on radeonsi, i965 and classical swrast. The v2 version incorporating the reiview comments was not yet run on piglit. Please review.
Looks good. Reviewed-by: Brian Paul <bri...@vmware.com> I don't remember, do you need me to push these for you? -Brian _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
