On 14 February 2018 at 11:39, Daniel Stone <dan...@fooishbar.org> wrote: > On 13 February 2018 at 22:15, Jason Ekstrand <ja...@jlekstrand.net> wrote: >> On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone <dan...@fooishbar.org> wrote: >>> On 9 February 2018 at 23:43, Jason Ekstrand <ja...@jlekstrand.net> wrote: >>> For actual scanout, the kernel very specifically demands that if the >>> BO is X-tiled, then set_tiling be called with TILING_X. This applies >>> even if we explicitly allocate with MOD_X_TILED and pass that in via >>> drmModeAddFB2WithModifiers: there is an explicit check for >>> !!(bo_tiling == TILING_X) == !!(modifier == MOD_X_TILED). > > You missed this bit. Suggested fixup: https://hastebin.com/xikopobiza
Er, except it should be (1 << b) everywhere, not b. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
